Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers

[Michael Walle]

Am 2020-03-09 20:59, schrieb Vladimir Oltean:
> On Mon, 9 Mar 2020 at 21:06, Michael Walle <michael@xxxxxxxx> wrote:
> > Am 2020-03-09 15:56, schrieb Vladimir Oltean:
> > > From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> > >
> > > LS1028A has a functional connection to the eDMA module. Even if the
> > > spi-fsl-dspi.c driver is not using DMA for LS1028A now, define the
> > > slots
> > > in the DMAMUX for connecting the eDMA channels to the 3 DSPI
> > > controllers.
> > >
> > > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 515e0a1b934f..18155273a46e 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -298,6 +298,8 @@
> > >                       interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> > >                       clock-names = "dspi";
> > >                       clocks = <&clockgen 4 1>;
> > > +                     dmas = <&edma0 0 62>, <&edma0 0 60>;
> > > +                     dma-names = "tx", "rx";
> >
> > minor nit. Other nodes specified the dma channels as
> >
> > dma-names = "tx", "rx";
> > dmas = <&edma0 0 62>,
> >         <&edma0 0 60>;
> >
> > -michael
>
> Does it matter?

No, therefore "minor nit". Its just formatted other then everything else 
in the file.

-michael