Re: [v1 1/3] media: dt-bindings: ov8856: Document YAML bindings

From: Robert Foss
Date: Tue Mar 10 2020 - 11:51:50 EST


Hey Fabio,

Thanks for having a look at this series so quickly.

On Tue, 10 Mar 2020 at 14:57, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Robert,
>
> On Tue, Mar 10, 2020 at 10:46 AM Robert Foss <robert.foss@xxxxxxxxxx> wrote:
>
> > + ov8856: camera-sensor@10 {
> > + compatible = "ovti,ov8856";
> > + reg = <0x10>;
> > + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>;
>
> Could you double check this is correct? Other OmniVision sensors have
> reset-gpios as active low.

I have tested this, unfortunately I don't have access to a ov8856
datasheet that includes
this level of detail. But I have tested this.

>
> I suspect that the driver has also an inverted logic, so that's why it works.

That could explain it still working. Let me have a look into the
driver and see what it does.

>
> I don't have access to the datasheet though, so I am just guessing.

Me neither unfortunately, if anyone does have a link for it, I would
very much appreciate it.