Re: [PATCH v2 1/4] kernfs: kvmalloc xattr value instead of kmalloc

From: Shakeel Butt
Date: Tue Mar 10 2020 - 15:40:14 EST


Hi Daniel,

On Thu, Mar 5, 2020 at 1:16 PM Daniel Xu <dxu@xxxxxxxxx> wrote:
>
> It's not really necessary to have contiguous physical memory for xattr
> values. We no longer need to worry about higher order allocations
> failing with kvmalloc, especially because the xattr size limit is at
> 64K.
>
> Signed-off-by: Daniel Xu <dxu@xxxxxxxxx>

The patch looks fine to me. However the commit message is too cryptic
i.e. hard to get the motivation behind the change.