Re: [PATCH 12/20] fuse: Introduce setupmapping/removemapping commands

From: Miklos Szeredi
Date: Tue Mar 10 2020 - 15:50:02 EST


On Wed, Mar 4, 2020 at 5:59 PM Vivek Goyal <vgoyal@xxxxxxxxxx> wrote:
>
> Introduce two new fuse commands to setup/remove memory mappings. This
> will be used to setup/tear down file mapping in dax window.
>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> Signed-off-by: Peng Tao <tao.peng@xxxxxxxxxxxxxxxxx>
> ---
> include/uapi/linux/fuse.h | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
> index 5b85819e045f..62633555d547 100644
> --- a/include/uapi/linux/fuse.h
> +++ b/include/uapi/linux/fuse.h
> @@ -894,4 +894,41 @@ struct fuse_copy_file_range_in {
> uint64_t flags;
> };
>
> +#define FUSE_SETUPMAPPING_ENTRIES 8
> +#define FUSE_SETUPMAPPING_FLAG_WRITE (1ull << 0)
> +struct fuse_setupmapping_in {
> + /* An already open handle */
> + uint64_t fh;
> + /* Offset into the file to start the mapping */
> + uint64_t foffset;
> + /* Length of mapping required */
> + uint64_t len;
> + /* Flags, FUSE_SETUPMAPPING_FLAG_* */
> + uint64_t flags;
> + /* Offset in Memory Window */
> + uint64_t moffset;
> +};
> +
> +struct fuse_setupmapping_out {
> + /* Offsets into the cache of mappings */
> + uint64_t coffset[FUSE_SETUPMAPPING_ENTRIES];
> + /* Lengths of each mapping */
> + uint64_t len[FUSE_SETUPMAPPING_ENTRIES];
> +};

fuse_setupmapping_out together with FUSE_SETUPMAPPING_ENTRIES seem to be unused.

Thanks,
Miklos