Re: [PATCH 3/3 RESEND] perf/amd/uncore: Add support for Family 19h L3 PMU

From: Borislav Petkov
Date: Thu Mar 12 2020 - 10:14:12 EST


On Wed, Mar 11, 2020 at 02:13:23PM -0500, Kim Phillips wrote:
> Family 19h introduces a change in slice, core and thread specification
> in its L3 Performance Event Select (ChL3PmcCfg) register. We implement
> the new bitmask conversions in a new path in l3_thread_slice_mask()
> based on a family 19h-and-above check.
>
> We also change the uncore_init() family check to 19h-and-above, so as
> to not revert to the Family 16h-or-below L2/NB code paths in the driver.

Pls use passive voice in your commit message: no "we" or "I", etc, and
describe your changes in imperative mood.

Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette