Re: [PATCH v5 01/23] irqchip/gic-v3: Use SGIs without active state if offered

From: Marc Zyngier
Date: Thu Mar 12 2020 - 13:23:47 EST


Hi Eric,

On 2020-03-12 17:16, Auger Eric wrote:
Hi Marc,

[...]

diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
index 83439bfb6c5b..c29a02678a6f 100644
--- a/include/linux/irqchip/arm-gic-v3.h
+++ b/include/linux/irqchip/arm-gic-v3.h
@@ -57,6 +57,7 @@
#define GICD_SPENDSGIR 0x0F20

#define GICD_CTLR_RWP (1U << 31)
+#define GICD_CTLR_nASSGIreq (1U << 8)
I am not able to find this bit in Arm IHI 0069F (ID022020)
same for the bit in GICD_TYPER. Do we still miss part of the spec?

See my response to Zenghui (TL;DR: this addition to the spec missed the
cut-off for revision F and will be added in the next round).

Thanks,

M.
--
Jazz is not dead. It just smells funny...