Re: [PATCH] net/bpfilter: fix dprintf usage for logging into /dev/kmsg

From: David Miller
Date: Thu Mar 12 2020 - 18:34:59 EST


From: Bruno Meneguele <bmeneg@xxxxxxxxxx>
Date: Thu, 12 Mar 2020 17:12:40 -0300

> The bpfilter UMH code was recently changed to log its informative messages to
> /dev/kmsg, however this interface doesn't support SEEK_CUR yet, used by
> dprintf(). As result dprintf() returns -EINVAL and doesn't log anything.
>
> Although there already had some discussions about supporting SEEK_CUR into
> /dev/kmsg in the past, it wasn't concluded. Considering the only
> user of that interface from userspace perspective inside the kernel is the
> bpfilter UMH (userspace) module it's better to correct it here instead of
> waiting a conclusion on the interface changes.
>
> Signed-off-by: Bruno Meneguele <bmeneg@xxxxxxxxxx>

Please repost this with a proper Fixes: tag.

Thank you.