Re: [PATCH 1/2] cdc_ncm: Implement the 32-bit version of NCM Transfer Block

From: ÐÐÐÐÑÐÐÐÑ ÐÐÑÑÐÐÐÐ
Date: Sun Mar 15 2020 - 00:14:48 EST


Got it, thank you.

Done, sent the follow-up fix by itself relative to net-next tree.

Please let me know if you need squashed version.

Best,
Alexander Bersenev

ÑÐ, 14 ÐÐÑ. 2020 Ð. Ð 08:44, David Miller <davem@xxxxxxxxxxxxx>:
>
> From: Alexander Bersenev <bay@xxxxxxxxxxxx>
> Date: Sat, 14 Mar 2020 02:38:20 +0500
>
> > The NCM specification defines two formats of transfer blocks: with 16-bit
> > fields (NTB-16) and with 32-bit fields (NTB-32). Currently only NTB-16 is
> > implemented.
> >
> > This patch adds the support of NTB-32. The motivation behind this is that
> > some devices such as E5785 or E5885 from the current generation of Huawei
> > LTE routers do not support NTB-16. The previous generations of Huawei
> > devices are also use NTB-32 by default.
> >
> > Also this patch enables NTB-32 by default for Huawei devices.
> >
> > During the 2019 ValdikSS made five attempts to contact Huawei to add the
> > NTB-16 support to their router firmware, but they were unsuccessful.
> >
> > Signed-off-by: Alexander Bersenev <bay@xxxxxxxxxxxx>
>
> This patch is already in my net-next tree.
>
> You need to submit the follow-up fix all by itself, relative to my
> net-next GIT tree.
>
> You must always post patches against the GIT tree that your change
> is targetting, that way you will avoid situations like this.
>
> Thank you.