Re: [RFC][PATCH v4 23/69] merging pick_link() with get_link(), part 5

From: Al Viro
Date: Sun Mar 15 2020 - 10:24:04 EST


On Sun, Mar 15, 2020 at 05:53:23PM +0800, Hillf Danton wrote:

> > + res = step_into(nd, 0, dentry, inode, seq);
> > + if (unlikely(res)) {
>
> Need to check that res is not err.
>
> > + nd->flags |= LOOKUP_PARENT;
> > + nd->flags &= ~(LOOKUP_OPEN|LOOKUP_CREATE|LOOKUP_EXCL);
> > + nd->stack[0].name = NULL;
> > + return res;
> > }

Not really...