Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M

From: Arnd Bergmann
Date: Mon Mar 16 2020 - 04:05:36 EST


On Mon, Mar 16, 2020 at 7:43 AM Peng Fan <peng.fan@xxxxxxx> wrote:
> > Subject: Re: [PATCH 3/3] soc: imx: select ARM_GIC_V3 for i.MX8M
> >
> > On Fri, Mar 13, 2020 at 4:34 AM <peng.fan@xxxxxxx> wrote:
> > >
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Select ARM_GIC_V3, then it is able to use gic v3 driver in aarch32
> > > mode linux on aarch64 hardware. For aarch64 mode, it not hurts to
> > > select ARM_GIC_V3.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> >
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > > 70019cefa617..0b69024296d5 100644
> > > --- a/drivers/soc/imx/Kconfig
> > > +++ b/drivers/soc/imx/Kconfig
> > > @@ -21,6 +21,7 @@ config SOC_IMX8M
> > > bool "i.MX8M SoC family support"
> > > depends on ARCH_MXC || COMPILE_TEST
> > > default ARCH_MXC && ARM64
> > > + select ARM_GIC_V3
> >
> > It would seem sensible to also drop the dependency on the 'default'
>
> If drop default, we need enable this config option in ARM64 defconfig,
> I would leave it as is for now.

I meant making it 'default ARCH_MXC' so it gets enabled for both
32-bit and 64-bit i.MX configurations, not just 64-bit.

Arnd