Re: [PATCH] arm64: move kimage_vaddr to .rodata

From: Rémi Denis-Courmont
Date: Mon Mar 16 2020 - 06:32:36 EST


Le torstaina 12. maaliskuuta 2020, 18.40.36 EET Mark Rutland a Ãcrit :
> On Thu, Mar 12, 2020 at 11:40:02AM +0200, RÃmi Denis-Courmont wrote:
> > From: Remi Denis-Courmont <remi.denis.courmont@xxxxxxxxxx>
> >
> > This datum is not referenced from .idmap.text: it does not need to be
> > mapped in idmap. Lets move it to .rodata as it is never written to after
> > early boot of the primary CPU.
> > (Maybe .data.ro_after_init would be cleaner though?)
>
> Can we move this into arch/arm64/mm/mmu.c, where we already have
>
> kimage_voffset:
> | u64 kimage_voffset __ro_after_init;
> | EXPORT_SYMBOL(kimage_voffset);
>
> ... or is it not possible to initialize kimage_vaddr correctly in C?

Currently TEXT_OFFSET is defined by the Makefile only for assembler sources and
the linker script. So that would need to be exposed to CPPFLAGS as well.

--
ÐÐÐÐ ÐÑÐÐ-ÐÑÑÐÐÐ
http://www.remlab.net/