Re: [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore

From: Waiman Long
Date: Tue Mar 17 2020 - 14:10:05 EST


On 3/16/20 7:50 AM, David Howells wrote:
> Waiman Long <longman@xxxxxxxxxx> wrote:
>
>> include/linux/key-type.h | 2 +-
>> security/keys/big_key.c | 11 ++---
>> security/keys/encrypted-keys/encrypted.c | 7 ++-
>> security/keys/keyctl.c | 57 +++++++++++++++++++----
>> security/keys/keyring.c | 6 +--
>> security/keys/request_key_auth.c | 7 ++-
>> security/keys/trusted-keys/trusted_tpm1.c | 14 +-----
>> security/keys/user_defined.c | 5 +-
>> ...
>> - long (*read)(const struct key *key, char __user *buffer, size_t buflen);
>> + long (*read)(const struct key *key, char *buffer, size_t buflen);
> Note that there are read functions outside of security/keys/ that also need
> fixing - dns_resolver_read() and rxrpc_read().
>
> David

Yes, I am going to fix that. Sorry for the delay as I am juggling a few
different tasks.

Cheers,
Longman