Re: [v3 PATCH 1/2] mm: swap: make page_evictable() inline
From: Matthew Wilcox
Date: Tue Mar 17 2020 - 15:21:41 EST
On Wed, Mar 18, 2020 at 01:42:50AM +0800, Yang Shi wrote:
> -static inline int mapping_unevictable(struct address_space *mapping)
> +static inline bool mapping_unevictable(struct address_space *mapping)
> {
> if (mapping)
> return test_bit(AS_UNEVICTABLE, &mapping->flags);
Shouldn't this be:
-static inline int mapping_unevictable(struct address_space *mapping)
+static inline bool mapping_unevictable(struct address_space *mapping)
{
- if (mapping)
- return test_bit(AS_UNEVICTABLE, &mapping->flags);
- return !!mapping;
+ return mapping && test_bit(AS_UNEVICTABLE, &mapping->flags);
}