Re: [PATCH v2 19/19] objtool: Detect loading function pointers across noinstr

From: kbuild test robot
Date: Wed Mar 18 2020 - 03:18:49 EST


Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on next-20200317]
[cannot apply to tip/x86/core linux/master linus/master v5.6-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Peter-Zijlstra/objtool-vmlinux-o-and-noinstr-validation/20200318-035709
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 3168392536d32920349af53bdd108e3b92b10f4f
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

check.c: In function 'validate_rela':
>> check.c:2131:2: error: enumeration value 'INSN_JUMP_DYNAMIC' not handled in switch [-Werror=switch]
switch (insn->type) {
^~~~~~
>> check.c:2131:2: error: enumeration value 'INSN_JUMP_DYNAMIC_CONDITIONAL' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_RETURN' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_CONTEXT_SWITCH' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_STACK' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_BUG' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_NOP' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_STAC' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_CLAC' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_STD' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_CLD' not handled in switch [-Werror=switch]
>> check.c:2131:2: error: enumeration value 'INSN_OTHER' not handled in switch [-Werror=switch]
cc1: all warnings being treated as errors
mv: cannot stat 'tools/objtool/.check.o.tmp': No such file or directory
make[4]: *** [tools/build/Makefile.build:96: tools/objtool/check.o] Error 1
make[4]: Target '__build' not remade because of errors.
make[3]: *** [Makefile:46: tools/objtool/objtool-in.o] Error 2
make[3]: Target 'all' not remade because of errors.
make[2]: *** [Makefile:68: objtool] Error 2
make[1]: *** [Makefile:1787: tools/objtool] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:180: sub-make] Error 2
27 real 20 user 16 sys 132.12% cpu make prepare

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip