[PATCH v4 0/5] module autoloading fixes and cleanups

From: Eric Biggers
Date: Wed Mar 18 2020 - 19:06:17 EST


This series fixes a bug where request_module() was reporting success to
kernel code when module autoloading had been completely disabled via
'echo > /proc/sys/kernel/modprobe'.

It also addresses the issues raised on the original thread
(https://lkml.kernel.org/lkml/20200310223731.126894-1-ebiggers@xxxxxxxxxx/T/#u)
by documenting the modprobe sysctl, adding a self-test for the empty
path case, and downgrading a user-reachable WARN_ONCE().

Changed since v3:
- Added Fixes tag to the fs/filesystems.c patch, and mentioned why the
warning is continued to be printed once only.

Changed since v2:
- Adjusted the new documentation to avoid implicitly bringing up
module aliases, which are a more complex topic.
- Split the selftest patch into two patches, one to fix the test
numbering bug and one to add the new tests.

Changed since v1:
- Added patches to address the other issues raised on the thread.

Eric Biggers (5):
kmod: make request_module() return an error when autoloading is
disabled
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to
pr_warn_once()
docs: admin-guide: document the kernel.modprobe sysctl
selftests: kmod: fix handling test numbers above 9
selftests: kmod: test disabling module autoloading

Documentation/admin-guide/sysctl/kernel.rst | 25 +++++++++++-
fs/filesystems.c | 4 +-
kernel/kmod.c | 4 +-
tools/testing/selftests/kmod/kmod.sh | 43 +++++++++++++++++++--
4 files changed, 68 insertions(+), 8 deletions(-)


base-commit: 5076190daded2197f62fe92cf69674488be44175
--
2.25.1