Re: linux-next: Tree for Mar 18 (objtool)

From: Josh Poimboeuf
Date: Thu Mar 19 2020 - 13:46:00 EST


On Thu, Mar 19, 2020 at 12:40:32PM -0500, Josh Poimboeuf wrote:
> On Thu, Mar 19, 2020 at 12:33:31PM -0500, Josh Poimboeuf wrote:
> > On Thu, Mar 19, 2020 at 12:31:05PM -0500, Josh Poimboeuf wrote:
> > > ... except the __builtin_trap() UD2 seems to be coming *after* the BUG
> > > UD2. Could it be the BUG UD2 itself which is convincing UBSAN to add
> > > the __builtin_trap()?
> >
> > Actually I suspect it's the __builtin_unreachable() annotation which is
> > making UBSAN add the __builtin_trap()... because I don't see any double
> > UD2s for WARNs.
>
> Scratch that theory, removing the __builtin_unreachable() from
> unreachable() doesn't make the double UD2 go away.

Actually, removing __builtin_unreachable() *does* make the extra UD2 go
away -- I forgot I had some silly debug code.

Not sure what the "fix" should be though.

--
Josh