Re: [PATCH v12 03/10] firmware: Rename FW_OPT_NOFALLBACK to FW_OPT_NOFALLBACK_SYSFS

From: Hans de Goede
Date: Fri Mar 20 2020 - 12:42:26 EST


Hi,

On 3/20/20 3:02 PM, Greg Kroah-Hartman wrote:
On Wed, Mar 18, 2020 at 02:56:23PM +0100, Hans de Goede wrote:
Hi Greg,

On 3/18/20 2:27 PM, Greg Kroah-Hartman wrote:
On Fri, Jan 24, 2020 at 10:16:48AM +0100, Hans de Goede wrote:
Hi,

On 1/24/20 9:57 AM, Greg Kroah-Hartman wrote:
On Wed, Jan 15, 2020 at 05:35:47PM +0100, Hans de Goede wrote:
This is a preparation patch for adding a new platform fallback mechanism,
which will have its own enable/disable FW_OPT_xxx option.

Note this also fixes a typo in one of the re-wordwrapped comments:
enfoce -> enforce.

Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

I've taken this in my tree for now in a quest to try to get others to
pay attention to this series...

Thank you.

As mentioned before I believe that this series is ready for merging now.

Andy Lutomirski had one last change request for v12 of the second
patch in the series, specifically to replace the loop searching for
the prefix with a memem, but the kernel does not have memmem.

Andy, are you ok with v12 as is, given that we don't have memmem ?

Assuming Andy is ok with v12 as is, then to merge this we need
to probably wait for 5.6-rc1 and then have the x86/efi folks do
an immutable branch with the first 2 patches of the series.

Did this every happen? Or do I need to dump this all into my tree?

Ard has done a immutable branch with just the 2 patches:

https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/tag/?h=stable-shared-branch-for-driver-tree

I did not see any mails about this being pulled / merged, but I just
checked and this has landed in the tip tree 10 days ago:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/include/linux/efi.h?h=efi/core

So if you merge the stable-shared-branch-for-driver-tree tag and then
merge patches 3-8 of this series (or rather 4-8 since you already
merged 3 IIRC) that would be great.

Ok, I've merged the above branch with just the two patches, and the rest
of yours now,

Great, thank you!

sorry this took so long.

No problem, I'm quite happy this is queued for 5.7 now, I was
afraid it was going to slip to 5.8.

Regards,

Hans