Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx

From: Rob Herring
Date: Mon Mar 23 2020 - 10:21:05 EST


On Sun, Mar 22, 2020 at 3:09 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>
>
>
> On 3/20/2020 4:05 PM, Rob Herring wrote:
> >>>> Because the primary PHY0 can be autodetected by the bus scan.
> >>>> But I have nothing against your suggestions. Please, some one should say the
> >>>> last word here, how exactly it should be implemented?
> >>
> >> It's not for me to decide, I was hoping the Device Tree maintainers
> >> could chime in, your current approach would certainly work although it
> >> feels visually awkward.
> >
> > Something like this is what I'd do:
> >
> > ethernet-phy@4 {
> > compatible = "nxp,tja1102";
> > reg = <4 5>;
> > };
>
> But the parent (MDIO bus controller) has #address-cells = 1 and
> #size-cells = 0, so how can this be made to work without creating two
> nodes or a first node encapsulating another one?

That is the size of the address, not how many addresses there are. If
the device has 2 addresses, then 2 address entries seems entirely
appropriate.

Rob