Re: [PATCH] f2fs: remove redundant compress inode check

From: Jaegeuk Kim
Date: Tue Mar 24 2020 - 11:43:25 EST


On 03/24, Chao Yu wrote:
> Jaegeuk,
>
> Missed to apply this patch?
>
> On 2020/2/29 18:49, Chao Yu wrote:
> > due to f2fs_post_read_required() has did that.
> >
> > Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> > ---
> > fs/f2fs/f2fs.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> > index f4bcbbd5e9ed..882f9ad3445b 100644
> > --- a/fs/f2fs/f2fs.h
> > +++ b/fs/f2fs/f2fs.h
> > @@ -4006,8 +4006,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
> > return true;
> > if (f2fs_is_multi_device(sbi))
> > return true;
> > - if (f2fs_compressed_file(inode))
> > - return true;

I thought that we can keep this to avoid any confusion when porting to old
production kernel which uses ICE.

> > /*
> > * for blkzoned device, fallback direct IO to buffered IO, so
> > * all IOs can be serialized by log-structured write.
> >