Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

From: Miquel Raynal
Date: Tue Mar 24 2020 - 18:06:25 EST


Hi Xiaoming,

Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote on Fri, 20 Mar 2020 11:15:11
+0800:

> mtdblock_flush()
> -->write_cached_data()
> --->erase_write()
> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>
> Because mtdblock_flush() always returns 0,
> even if write_cached_data() fails and data is not written to the device,
> syscall_write() still returns success

I reworded a bit the commit log and also added a ' ' after 'mtd:' in
the title when applying.

Thanks,
MiquÃl