Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

From: Xiaoming Ni
Date: Wed Mar 25 2020 - 03:54:17 EST


On 2020/3/25 6:06, Miquel Raynal wrote:
Hi Xiaoming,

Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote on Fri, 20 Mar 2020 11:15:11
+0800:

mtdblock_flush()
-->write_cached_data()
--->erase_write()
mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed

Because mtdblock_flush() always returns 0,
even if write_cached_data() fails and data is not written to the device,
syscall_write() still returns success

I reworded a bit the commit log and also added a ' ' after 'mtd:' in
the title when applying.

Thanks,
MiquÃl

Your revised commit log is more accurate and clearer, thanks for your correction
Thanks.
Xiaoming Ni