[PATCH 02/10] objtool: check: Remove redundant checks on operand type

From: Julien Thierry
Date: Wed Mar 25 2020 - 04:42:26 EST


POP operations are already in code path where destination operand
is OP_DEST_REG. There is no need to check the operand type again.

Signed-off-by: Julien Thierry <jthierry@xxxxxxxxxx>
---
tools/objtool/check.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index a2c62bc82907..44a3abbb0b0b 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1730,15 +1730,13 @@ static int update_insn_state(struct instruction *insn, struct insn_state *state)

case OP_SRC_POP:
case OP_SRC_POPF:
- if (!state->drap && op->dest.type == OP_DEST_REG &&
- op->dest.reg == cfa->base) {
+ if (!state->drap && op->dest.reg == cfa->base) {

/* pop %rbp */
cfa->base = CFI_SP;
}

if (state->drap && cfa->base == CFI_BP_INDIRECT &&
- op->dest.type == OP_DEST_REG &&
op->dest.reg == state->drap_reg &&
state->drap_offset == -state->stack_size) {

--
2.21.1