Re: [PATCH] x86/smpboot: Remove 486-isms from the modern AP boot path

From: Thomas Gleixner
Date: Wed Mar 25 2020 - 10:38:22 EST


hpa@xxxxxxxxx writes:
> On March 25, 2020 3:14:31 AM PDT, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>>@@ -1118,7 +1121,7 @@ static int do_boot_cpu(int apicid, int cpu,
>>struct task_struct *idle,
>> }
>> }
>>
>>- if (x86_platform.legacy.warm_reset) {
>>+ if (!APIC_INTEGRATED(boot_cpu_apic_version)) {
>> /*
>> * Cleanup possible dangling ends...
>> */
>
> We don't support SMP on 486 and haven't for a very long time. Is there
> any reason to retain that code at all?

Not that I'm aware off.

Thanks,

tglx