Re: [PATCH 1/2] of: gpio unittest kfree() wrong object

From: Geert Uytterhoeven
Date: Thu Mar 26 2020 - 03:51:51 EST


On Thu, Mar 26, 2020 at 2:47 AM <frowand.list@xxxxxxxxx> wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> kernel test robot reported "WARNING: held lock freed!" triggered by
> unittest_gpio_remove(). unittest_gpio_remove() was unexpectedly
> called due to an error in overlay tracking. The remove had not
> been tested because the gpio overlay removal tests have not been
> implemented.
>
> kfree() gdev instead of pdev.
>
> Fixes: f4056e705b2e ("of: unittest: add overlay gpio test to catch gpio hog problem")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds