Re: [PATCH] net/mlx5: improve some comments

From: Saeed Mahameed
Date: Thu Apr 02 2020 - 22:34:07 EST


On Wed, 2020-04-01 at 21:14 +0800, Hu Haowen wrote:
> On 2020/4/1 8:57 PM, Hu Haowen wrote:
> > Added a missing space character and replaced "its" with "it's".
>
> Sorry, this patch does not include space character adding. Please
> ignore and delete that part of the commit message.
>

Hi,

Thanks for the patch I will apply and fix the commit message. BUT..
net-next is closed and the rules apply to everyone, even mlx5 branch,
so please for next time, let's wait for net-next to open.

Thanks,
Saeed.

>
> > Signed-off-by: Hu Haowen <xianfengting221@xxxxxxx>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > index c9c9b479bda5..0a8adda073c2 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > @@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct
> > work_struct *work)
> > get_block_timestamp(tracer,
> > &tmp_trace_block[TRACES_PER_BLOCK - 1]);
> >
> > while (block_timestamp > tracer->last_timestamp) {
> > - /* Check block override if its not the first block */
> > + /* Check block override if it's not the first block */
> > if (!tracer->last_timestamp) {
> > u64 *ts_event;
> > /* To avoid block override be the HW in case of
> > buffer