Re: [PATCH 00/32] staging: wfx: rework the Tx queue

From: Dan Carpenter
Date: Fri Apr 03 2020 - 04:04:02 EST

Next message: Jitao Shi: "[PATCH v14 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current"
Previous message: Yoshihiro Shimoda: "RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST"
In reply to: Jerome Pouiller: "[PATCH 06/32] staging: wfx: drop useless queue_id field"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I didn't quite finish reviewing these pathches last night. Looks good.
You will need a check on "ssidlen" to prevent memory corruption, as
discussed in patch 1, but that's not a bug which was introduced by this
patchset. None of my other comments really applied to the patchset
itself, just to the surrounding code.

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter

Next message: Jitao Shi: "[PATCH v14 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current"
Previous message: Yoshihiro Shimoda: "RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST"
In reply to: Jerome Pouiller: "[PATCH 06/32] staging: wfx: drop useless queue_id field"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]