Re: [PATCH -next] clk: zynqmp: Make zynqmp_clk_get_max_divisor static

From: Michal Simek
Date: Fri Apr 03 2020 - 04:38:14 EST


On 03. 04. 20 10:30, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/clk/zynqmp/divider.c:259:5: warning:
> symbol 'zynqmp_clk_get_max_divisor' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/clk/zynqmp/divider.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
> index 4be2cc76aa2e..1e93a4d32fa9 100644
> --- a/drivers/clk/zynqmp/divider.c
> +++ b/drivers/clk/zynqmp/divider.c
> @@ -256,7 +256,7 @@ static const struct clk_ops zynqmp_clk_divider_ops = {
> * Return: Maximum divisor of a clock if query data is successful
> * U16_MAX in case of query data is not success
> */
> -u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
> +static u32 zynqmp_clk_get_max_divisor(u32 clk_id, u32 type)
> {
> const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
> struct zynqmp_pm_query_data qdata = {0};
>

Reviewed-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal