Re: [PATCH v3] mm: cma: NUMA node interface

From: Michal Hocko
Date: Fri Apr 03 2020 - 06:01:25 EST


On Fri 03-04-20 10:51:32, Aslan Bakirov wrote:
> On Fri, Apr 3, 2020 at 6:02 AM Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
>
> > On Thu, Apr 02, 2020 at 07:12:56PM -0700, Aslan Bakirov wrote:
> > > I've noticed that there is no interfaces exposed by CMA which would let
> > me
> > > to declare contigous memory on particular NUMA node.
> > >
> > > This patchset adds the ability to try to allocate contiguous memory on
> > > specific node. It will fallback to other nodes if the specified one
> > > doesn't work.
> > >
> > > Implement a new method for declaring contigous memory on particular node
> > > and keep cma_declare_contiguous() as a wrapper.
> >
> > Is there an additional patch which uses this new interface?
> >
> > Generally the patch seems reasonable but we should have a user.
>
>
> Thanks for the comments. Yes, actually, this is the version 3 of first
> patch ([PATCH 1/2] mm: cma: NUMA node interface)
> of patchset. Second patch, which uses this interface is "[PATCH 2/2] mm:
> hugetlb: Use node interface of cma"

It would have been much more clear to send those two patches together as
you can see.
--
Michal Hocko
SUSE Labs