Re: [PATCH 2/2] ARM: dts: aspeed: zaius: Add gpio line names

From: Andrew Geissler
Date: Fri Apr 03 2020 - 12:19:07 EST




> On Apr 2, 2020, at 7:51 PM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
>
>
>
> On Tue, 31 Mar 2020, at 04:46, Andrew Geissler wrote:
>>
>>
>>> On Mar 26, 2020, at 6:20 PM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
>>>
>>>
>>>
>>> On Sat, 7 Mar 2020, at 03:32, Andrew Geissler wrote:
>>>> Name the GPIOs to help userspace work with them. The names describe the
>>>> functionality the lines provide, not the net or ball name. This makes it
>>>> easier to share userspace code across different systems and makes the
>>>> use of the lines more obvious.
>>>>
>>>> Signed-off-by: Andrew Geissler <geissonator@xxxxxxxxx>
>>>
>>> So we're creating a bit of an ad-hoc ABI here between the DT and userspace.
>>>
>>> Where are we documenting it?
>>
>> Yeah, so far itâs basically design by precedent. If you want your OpenBMC
>> function to work then follow the standards we're setting in other dtsâs.
>>
>> Is there a good place to document this? I could create a OpenBMC design
>> doc but that would not address non-OpenBMC areas.
>
> Don't let perfect be the enemy of good enough :) Lets document it in OpenBMC
> and then look at alternatives if we find it's necessary. I don't think we will given
> that the contract is between the kernel and OpenBMC userspace.

Ok, I put a doc up for review here:
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/30988

>
> Andrew