Re: [PATCH v5]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()

From: LABBE Corentin
Date: Fri Apr 03 2020 - 14:43:15 EST


On Fri, Apr 03, 2020 at 07:14:29PM +0800, Tang Bin wrote:
> When something goes wrong, platform_get_irq() will print an error message,
> so in order to avoid the situation of repeat outputïwe should remove
> dev_err here.
>
> Changes from v4:
> - rewrite the code, because the code in v4 is wrong, sorry.
>
> Changes form v3:
> - fix the theme writing error.
>
> Changes from v2:
> - modify the theme format and content description.
> - reformat the patch, it's the wrong way to resubmit a new patch that
> should be modified on top of the original. The original piece is:
> https://lore.kernel.org/patchwork/patch/1219611/
>
> Changes from v1:
> - the title has changed, because the description is not very detailed.
> - the code has been modified, because it needs to match the theme.
>
> Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> ---

Hello

The changelog should not be in the commit message.
You should set them after the "---" line

Thanks