[PATCH] gpio: msic: Delete an error message in platform_msic_gpio_probe()

From: Markus Elfring
Date: Sat Apr 04 2020 - 15:35:37 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 4 Apr 2020 21:30:12 +0200

The function âplatform_get_irqâ can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/gpio/gpio-msic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index 7e3c96e4ab2c..5548b7be36b3 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -248,10 +248,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
int retval;
int i;

- if (irq < 0) {
- dev_err(dev, "no IRQ line: %d\n", irq);
+ if (irq < 0)
return irq;
- }

if (!pdata || !pdata->gpio_base) {
dev_err(dev, "incorrect or missing platform data\n");
--
2.26.0