Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments

From: William Kucharski
Date: Sun Apr 05 2020 - 01:26:30 EST




> On Apr 4, 2020, at 12:52 PM, Uladzislau Rezki <urezki@xxxxxxxxx> wrote:
>
>>
>> ïIs there any need to similarly sanitize âsizeâ to assure start + size doesnât go past âend?â
>>
> Why is that double check needed if all such tests are done deeper on stack?

If such tests ARE performed, then it doesn't matter to me whether it is checked before or after,
it just seems that nothing checks whether start + size makes some sort of sense with respect
to end.

I admit I didn't walk through all the routines to see if such a check would be superfluous.