Re: [PATCH] MIPS: fw: arc: add __weak to prom_meminit and prom_free_prom_memory

From: Maciej W. Rozycki
Date: Sun Apr 05 2020 - 13:17:04 EST


On Mon, 6 Apr 2020, Masahiro Yamada wrote:

> As far as I understood, prom_meminit() in arch/mips/fw/arc/memory.c
> is overridden by the one in arch/mips/sgi-ip32/ip32-memory.c if
> CONFIG_SGI_IP32 is enabled.
>
> The use of EXPORT_SYMBOL in static libraries potentially causes a
> problem for the llvm linker [1]. So, I want to forcibly link lib-y
> objects to vmlinux when CONFIG_MODULES=y.

It looks to me like a bug in the linker in the handling of the EXTERN
command. Why not fix the linker instead?

Maciej