Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

[Jani Nikula]

On Tue, 07 Apr 2020, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:
>> On Mar 27, 2020, at 19:03, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:
>> 
>> Hi,
>> 
>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:
>>> 
>>> There's another OLED panel needs to use DPCD aux interface to control
>>> backlight.
>>> 
>>> BugLink: https://bugs.launchpad.net/bugs/1860303
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
>> 
>> Would it be possible to review this?
>> I'd like to send a similar quirk for a new panel, and I want to avoid causing any merge conflict.
>
> Another gentle ping...

Can't really review, but if you say that's needed...

Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>

>
>> 
>> Kai-Heng
>> 
>>> ---
>>> drivers/gpu/drm/drm_dp_helper.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> 
>>> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
>>> index 8ba4531e808d..a0d4314663de 100644
>>> --- a/drivers/gpu/drm/drm_dp_helper.c
>>> +++ b/drivers/gpu/drm/drm_dp_helper.c
>>> @@ -1301,6 +1301,8 @@ static const struct edid_quirk edid_quirk_list[] = {
>>> 	 * only supports DPCD backlight controls
>>> 	 */
>>> 	{ MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> +	/* HP Spectre x360 Convertible 13t-aw100 */
>>> +	{ MFG(0x4c, 0x83), PROD_ID(0x42, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
>>> 	/*
>>> 	 * Some Dell CML 2020 systems have panels support both AUX and PWM
>>> 	 * backlight control, and some only support AUX backlight control. All
>>> -- 
>>> 2.17.1
>>> 
>> 
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Graphics Center