Re: [Cocci] Coccinelle rule for CVE-2019-18683

From: Alexander Popov
Date: Thu Apr 09 2020 - 14:11:51 EST


Markus, thanks for your remarks!

On 09.04.2020 11:41, Markus Elfring wrote:
> * The source code search pattern can be too generic.
> How do you think about to consider additional constraints
> for safer data control flow analysis?

Could you please elaborate on that?

I used 'exists' keyword to find at least one branch that has
mutex_unlock+kthread_stop+mutex_lock chain.

> * Other operation modes might become helpful.

Thanks! I added 'context' mode, it's very good for this purpose.

Best regards,
Alexander