Re: [PATCH V4 6/6] x86/Hyper-V: Report crash data in die() when panic_on_oops is set

From: Wei Liu
Date: Fri Apr 10 2020 - 10:28:05 EST


On Thu, Apr 09, 2020 at 11:06:13PM +0000, Michael Kelley wrote:
> From: Wei Liu <wei.liu@xxxxxxxxxx> Sent: Thursday, April 9, 2020 9:41 AM
> >
> > On Wed, Apr 08, 2020 at 08:19:47PM +0000, Michael Kelley wrote:
> > > From: Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx> Sent: Monday, April 6, 2020 8:54 AM
> > > >
> > > > When oops happens with panic_on_oops unset, the oops
> > > > thread is killed by die() and system continues to run.
> > > > In such case, guest should not report crash register
> > > > data to host since system still runs. Check panic_on_oops
> > > > and return directly in hyperv_report_panic() when the function
> > > > is called in the die() and panic_on_oops is unset. Fix it.
> > > >
> > > > Fixes: 7ed4325a44ea ("Drivers: hv: vmbus: Make panic reporting to be more useful")
> > > > Signed-off-by: Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>
> > > > ---
> > > > Change since v3:
> > > > - Fix compile error.
> > > > - Add fix commit in the change log
> > > > ---
> > > > arch/x86/hyperv/hv_init.c | 6 +++++-
> > > > drivers/hv/vmbus_drv.c | 5 +++--
> > > > include/asm-generic/mshyperv.h | 2 +-
> > > > 3 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> >
> > It seems to me only the last patch is new, others are already in my
> > tree, so I only apply the last one.
> >
> > Let me know if my understanding is wrong.
> >
>
> Tianyu added "Fixes:" tags to some of the other patches in
> the series. It appears the version you had already queued doesn't
> have those "Fixes:" tags.

Oh, I only read the subject lines and checked the Reviewed-by tags. I
will queue the new series instead.

Wei.

>
> Michael