Re: [PATCH] checkpatch: check for missing \n at the end of logging message

[Christophe JAILLET]

Le 11/04/2020 Ã 12:17, Joe Perches a ÃcritÂ:
> On Sat, 2020-04-11 at 09:12 +0200, Christophe JAILLET wrote:
> > 	./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
> >
> > is missing line 189, even if it looks like a construction correctly spotted in some other files:
> > 	if (foo) {
> > 		dev_err(...);
> > 		...
> > 	};
> Hi Christophe, many thanks for doing more testing
>
> Are you sure about this one?  I get:
>
> $ ./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
> WARNING: Possible missing '\n' at the end of a logging message format string
> #189: FILE: drivers/soc/kendryte/k210-sysctl.c:189:
> +		dev_err(&pdev->dev, "failed to register clk");
No, this one is correctly spotted.
(I added the missing \n, then ran checkpatch.pl, then wondered why it 
was not spotting the issue!)

CJ