Re: [RFC][PATCH 03/36] objtool: Enable compilation of objtool for all architectures

From: Steven Rostedt
Date: Tue Apr 14 2020 - 09:41:44 EST


On Tue, 14 Apr 2020 08:39:23 +0100
Julien Thierry <jthierry@xxxxxxxxxx> wrote:

> My concern with this it that most of the structures and code in arch.h
> and check.c can/should be reused across architectures. So, when
> providing support for a new architecutre, the first thing that will be
> needed is to move those back under tools/objtool whithout disturbing the
> arches that don't yet provide support for "check" subcommand.

Are all the enums and structs in arch.h non-arch specific?

Or would they need to be split?

>
> So, if it is decided that recordmcount should be an objtool subcommand,
> the code itself should probably stay under tools/objtool and then have
> different compilation configurations for objtool depending on the
> architecture (e.g. HAVE_OBJTOOL_CHECK, HAVE_OBJTOOL_ORC) or something of
> the sort.

That could work.

-- Steve