Re: [PATCH v6 0/6] clockevent: add low power STM32 timer

From: Lee Jones
Date: Thu Apr 16 2020 - 03:03:59 EST


On Wed, 01 Apr 2020, Benjamin Gaignard wrote:

> This series add low power timer as boadcast clockevent device.
> Low power timer could runs even when CPUs are in idle mode and
> could wakeup them.
>
> version 6:
> - simplify binding, DT and code to use only one interrupt
>
> version 5:
> - document interrupts and interrupt-names bindings
> - use a different wake up interrupt
> - add device-tree patch
> - make STM32MP157 select low power timer configuration flag
> - enable fast_io in regmap configuration
>
> version 4:
> - move defines in mfd/stm32-lptimer.h
> - change compatible and subnode names
> - document wakeup-source property
> - reword commit message
> - make driver Kconfig depends of MFD_STM32_LPTIMER
> - remove useless include
> - remove rate and clk fields from the private structure
> - to add comments about the registers sequence in stm32_clkevent_lp_set_timer
> - rework probe function and use devm_request_irq()
> - do not allow module to be removed
>
> version 3:
> - fix timer set sequence
> - don't forget to free irq on remove function
> - use devm_kzalloc to simplify errors handling in probe function
>
> version 2:
> - stm32 clkevent driver is now a child of the stm32 lp timer node
> - add a probe function and adpat the driver to use regmap provide
> by it parent
> - stop using timer_of helpers
>
>
> Benjamin Gaignard (6):
> dt-bindings: mfd: Document STM32 low power timer bindings
> ARM: dts: stm32: Add timer subnodes on stm32mp15 SoCs
> mfd: stm32: Add defines to be used for clkevent purpose
> mfd: stm32: enable regmap fast_io for stm32-lptimer
> clocksource: Add Low Power STM32 timers driver
> ARM: mach-stm32: select low power timer for STM32MP157
>
> .../devicetree/bindings/mfd/st,stm32-lptimer.yaml | 21 ++
> arch/arm/boot/dts/stm32mp151.dtsi | 35 ++++
> arch/arm/mach-stm32/Kconfig | 1 +
> drivers/clocksource/Kconfig | 4 +
> drivers/clocksource/Makefile | 1 +
> drivers/clocksource/timer-stm32-lp.c | 221 +++++++++++++++++++++
> drivers/mfd/stm32-lptimer.c | 1 +
> include/linux/mfd/stm32-lptimer.h | 5 +

I'd be happy to take this set, but you need Acks from the other
subsystem Maintainers before I can do so.

> 8 files changed, 289 insertions(+)
> create mode 100644 drivers/clocksource/timer-stm32-lp.c
>

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog