I admit I didn't recheck, but I think the driver will also be matched onIn this driver, the function efm32_i2c_probe() can be triggered only if thediff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.cI don't care much about this change. While the statement that this
index 4de31fae7..4786ef6b2 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -312,9 +312,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
int ret;
u32 clkdiv;
- if (!np)
- return -EINVAL;
-
driver is only instantiated on dt platforms is probably right,
explicitly checking for it might still prevent surprises later, serves
as explicit statement for the driver reader that non-dt isn't supposed
to work and given that the check is cheap I tend slightly to just keep
it.
platform_device and platform_driver matches, and the matching condition is
DTS. It's my opinion.
non-dt platforms that provide an "efm32-i2c" device.