Re: [PATCH][next] drivers: hv: remove redundant assignment to pointer primary_channel

From: Dan Carpenter
Date: Thu Apr 16 2020 - 06:05:31 EST


We have this discussion over and over. I always say it helps to have
the commit mentioned in the commit message but it's not a Fixes tag.
So I think that the commit message should say something like
"commit 1234234 ("blah blah") removed some code so this variable isn't
used any more". I think it helps the review process. But then if we
mention the commit everyone says to use the Fixes tag.

It turns out if you leave out the commit entirely then people still
complain but a lot less frequently. It shouldn't work that way but
reviewers are illogical.

regards,
dan carpenter