Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer

From: Sedat Dilek
Date: Fri Apr 17 2020 - 04:06:19 EST


On Fri, Apr 17, 2020 at 10:03 AM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>
> Sedat Dilek <sedat.dilek@xxxxxxxxx> writes:
>
> > From: Chris Rorvick <chris@xxxxxxxxxxx>
> >
> > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> > ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> > check correctly.
> >
> > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> > Tweeted-by: @grsecurity
> > Message-Id: <20200402050219.4842-1-chris@xxxxxxxxxxx>
> > Signed-off-by: Chris Rorvick <chris@xxxxxxxxxxx>
> > Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>
> Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
> really needed in this case.
>

Thanks for all your suggestions and taking care, Kalle.

- Sedat -

> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches