Re: [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs

From: Guenter Roeck
Date: Fri Apr 17 2020 - 10:05:09 EST


On Thu, Apr 16, 2020 at 05:06:45PM -0700, Stephen Boyd wrote:
> Read the slv_id properly by making sure the 16-bit number is endian
> swapped from little endian to CPU native before we read it to figure out
> what to print for the human readable name. Otherwise we may just show
> that all the elements in the cmd-db are "Unknown" which isn't right.
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> drivers/soc/qcom/cmd-db.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: d6815c5c43d4f9d18e557d27fd27ae8d9cfd450c
> prerequisite-patch-id: fc235b174200bb1b24876628a89a841d1c2e4aad
> prerequisite-patch-id: df579afb4eaea4200733d9dffb1d75eef8d8360b
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 4f8b739c6485..fc5610603b17 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -254,7 +254,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
> if (!rsc->slv_id)
> break;
>
> - switch (rsc->slv_id) {
> + switch (le16_to_cpu(rsc->slv_id)) {
> case CMD_DB_HW_ARC:
> name = "ARC";
> break;