Re: [RFC net-next v5 2/9] bridge: mrp: Update Kconfig and Makefile

From: Nikolay Aleksandrov
Date: Sat Apr 18 2020 - 04:49:50 EST


On 14/04/2020 14:26, Horatiu Vultur wrote:
> Add the option BRIDGE_MRP to allow to build in or not MRP support.
> The default value is N.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> ---
> net/bridge/Kconfig | 12 ++++++++++++
> net/bridge/Makefile | 2 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/net/bridge/Kconfig b/net/bridge/Kconfig
> index e4fb050e2078..51a6414145d2 100644
> --- a/net/bridge/Kconfig
> +++ b/net/bridge/Kconfig
> @@ -61,3 +61,15 @@ config BRIDGE_VLAN_FILTERING
> Say N to exclude this support and reduce the binary size.
>
> If unsure, say Y.
> +
> +config BRIDGE_MRP
> + bool "MRP protocol"
> + depends on BRIDGE
> + default n
> + help
> + If you say Y here, then the Ethernet bridge will be able to run MRP
> + protocol to detect loops
> +
> + Say N to exclude this support and reduce the binary size.
> +
> + If unsure, say N.
> diff --git a/net/bridge/Makefile b/net/bridge/Makefile
> index 49da7ae6f077..9bf3e1be3328 100644
> --- a/net/bridge/Makefile
> +++ b/net/bridge/Makefile
> @@ -25,3 +25,5 @@ bridge-$(CONFIG_BRIDGE_VLAN_FILTERING) += br_vlan.o br_vlan_tunnel.o br_vlan_opt
> bridge-$(CONFIG_NET_SWITCHDEV) += br_switchdev.o
>
> obj-$(CONFIG_NETFILTER) += netfilter/
> +
> +bridge-$(CONFIG_BRIDGE_MRP) += br_mrp.o br_mrp_netlink.o br_mrp_switchdev.o
>

This is not bisectable, if you choose Y here you'll be missing some files.