Re: [patch 02/15] x86/cpu: Uninline CR4 accessors

From: Borislav Petkov
Date: Mon Apr 20 2020 - 05:34:36 EST


On Mon, Apr 20, 2020 at 02:01:02AM -0700, Christoph Hellwig wrote:
> While this is better than what we had before we really need to have
> a discussion on lkdtm - it needs a lot of crap that otherwise wouldn't
> be exported, and I'm really worried about people enabling it and thus
> adding exports even if they are conditional.

Thought the same too, while looking at that. It is fine and dandy that
it injects all kinds of crap into a running kernel but not at the price
of exporting such internal interfaces.

> Can we force the code to be built in require a boot option for it to
> be activated?

Yes please.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette