Re: [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

From: Jani Nikula
Date: Mon Apr 20 2020 - 06:28:55 EST


On Mon, 13 Apr 2020, Lyude Paul <lyude@xxxxxxxxxx> wrote:
> Looks like I accidentally made it so you couldn't force DPCD backlight
> support on, whoops. Fix that.

Thanks, pushed.

BR,
Jani.



>
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
> Fixes: 17f5d57915be ("drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel")
> Cc: Adam Jackson <ajax@xxxxxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Cc: "Ville SyrjÃlÃ" <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 4b916468540f..0722540d64ad 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -358,6 +358,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
> */
> if (i915->vbt.backlight.type !=
> INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
> + i915_modparams.enable_dpcd_backlight != 1 &&
> !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
> DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
> drm_info(&i915->drm,

--
Jani Nikula, Intel Open Source Graphics Center