Re: [GIT PULL] clang-format for v5.7-rc3

From: Ian Rogers
Date: Tue Apr 21 2020 - 17:03:36 EST


On Tue, Apr 21, 2020 at 12:10 PM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Apr 20, 2020 at 12:09 PM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> >
> > - Don't indent C++ namespaces (Ian Rogers)
>
> I've taken this, since it doesn't matter, but I'm wondering at the
> motivation for it (exactly because it shouldn't matter).

Hi Linus!

We (Google, Stephane Eranian, ..) have a tool that converts Intel's
topdown metrics:
https://download.01.org/perfmon/TMA_Metrics.xlsx
into the json format used for metrics in perf. It is written in C++
and we are planning to upstream it. In C++ there is preference for
anonymous namespaces over static functions and the namespace
indentation was pretty annoying for this. There's a little more
motivation in the commit message too.

Thanks,
Ian Rogers

> Linus