Re: [PATCH] kunit: Add missing newline in summary message

From: Marco Elver
Date: Wed Apr 22 2020 - 07:05:55 EST


On Fri, 17 Apr 2020 at 12:03, Alan Maguire <alan.maguire@xxxxxxxxxx> wrote:
>
> On Thu, 16 Apr 2020, Marco Elver wrote:
>
> > Add missing newline, as otherwise flushing of the final summary message
> > to the console log can be delayed.
> >
> > Fixes: e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
> > Signed-off-by: Marco Elver <elver@xxxxxxxxxx>
>
> Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
>
> Thanks for finding/fixing this!
>
> Alan
>
> > ---
> > lib/kunit/test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)

Which tree will pick this up? I cannot yet see this in -next.

Thanks,
-- Marco


> > diff --git a/lib/kunit/test.c b/lib/kunit/test.c
> > index 7a6430a7fca0..ccb2ffad8dcf 100644
> > --- a/lib/kunit/test.c
> > +++ b/lib/kunit/test.c
> > @@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
> > * representation.
> > */
> > if (suite)
> > - pr_info("%s %zd - %s",
> > + pr_info("%s %zd - %s\n",
> > kunit_status_to_string(is_ok),
> > test_number, description);
> > else
> > --
> > 2.26.1.301.g55bc3eb7cb9-goog
> >
> >