Re: [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison

[Yang Yingliang]

On 2020/4/24 18:12, Sergei Shtylyov wrote:
> Hello!
>
> On 24.04.2020 11:14, Yang Yingliang wrote:
>
> > The type of loaddr is u8 which is always '<=' 0xff, so the
> > loaddr <= 0xff is always true, we can remove this comparison.
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> > ---
> > Â drivers/ptp/ptp_clockmatrix.c | 2 +-
> > Â 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ptp/ptp_clockmatrix.c 
> > b/drivers/ptp/ptp_clockmatrix.c
> > index 032e112..56aee4f 100644
> > --- a/drivers/ptp/ptp_clockmatrix.c
> > +++ b/drivers/ptp/ptp_clockmatrix.c
> > @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
> > Â ÂÂÂÂÂÂÂÂÂÂÂÂÂ /* Page size 128, last 4 bytes of page skipped */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ if (((loaddr > 0x7b) && (loaddr <= 0x7f))
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ || ((loaddr > 0xfb) && (loaddr <= 0xff)))
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ || loaddr <= 0xff)
>
> ÂÂ Haven't you just said that this is always true? :-)

My bad, I sent the patch.

> [...]
>
> MBR, Sergei