Re: [PATCH net-next v2] ptp: clockmatrix: remove unnecessary comparison

From: Vincent Cheng
Date: Fri Apr 24 2020 - 09:22:52 EST


>Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
>---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
>index 032e112..56aee4f 100644
>--- a/drivers/ptp/ptp_clockmatrix.c
>+++ b/drivers/ptp/ptp_clockmatrix.c
>@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>
> /* Page size 128, last 4 bytes of page skipped */
> if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>+ || loaddr > 0xfb)
> continue;
>
> err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));

Thank-you for the fix.

Reviewed-by: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>